Found redundant literal in a logical expression JS-W1043
Anti-pattern
Minor
8 months ago
—
8 months old
Logical expression with a literal operand will always evaluate to the same value
36 }
37
38 private async _retry<RESPONSE>(fn: Observable<RESPONSE>, options?: IApiRequestOptions): Promise<ApiResponse<RESPONSE>> {
39 const maxRetries = options?.retries || 3;40 let lastError: HttpErrorResponse = new HttpErrorResponse({ status: 0 });
41 for (let i = 0; i < maxRetries; i++) {
42 try {
Description
Expressions that consistently result in either true or false when comparing values, and logical operations like ||, &&, and ?? that consistently either skip or fully evaluate their operands, often indicate mistakes. Logical operations that always yield the same result could lead to unexpected behavior or bugs in the program.
Bad Practice
const arrIsEmpty = someArr === [] // Will always evaluate to false
Recommended
const arrIsEmpty = someArr.length === 0