Private members should be marked as
readonly JS-0368
Anti-pattern
Major
8 months ago
—
8 months old
Member '_shortcut: ShortcutService' is never reassigned; mark it as
readonly11 height = window.innerHeight;
12 width = window.innerWidth;
13
14 constructor(private _shortcut: ShortcutService) {15 this._shortcut.initialize();
16 }
17
Description
Private members are marked as readonly if they're never modified outside of the constructor.
Bad Practice
class Container {
// These member variables could be marked as readonly
private neverModifiedMember = true;
private onlyModifiedInConstructor: number;
public constructor(
onlyModifiedInConstructor: number,
// Private parameter properties can also be marked as readonly
private neverModifiedParameter: string,
) {
this.onlyModifiedInConstructor = onlyModifiedInConstructor;
}
}
Recommended
class Container {
// Public members might be modified externally
public publicMember: boolean;
// Protected members might be modified by child classes
protected protectedMember: number;
// This is modified later on by the class
private modifiedLater = 'unchanged';
public mutate() {
this.modifiedLater = 'mutated';
}
}