Found unused variables in TypeScript code JS-0356
Performance
Major
8 days ago
—
a year old
'isSuccess' is assigned a value but never used
132 ? queryParams.data
133 : (['US', 0, 0, 0, 'mi'] as const)
134 const {
135 isSuccess,136 isFetching: searchIsFetching,
137 isLoading: searchIsLoading,
138 ...searchQuery'input' is defined but never used
4
5import { type TServiceModalSchema } from './query.serviceModal.schema'
6
7const serviceModal = async ({ ctx, input }: TRPCHandlerParams<TServiceModalSchema>) => { 8 try {
9 return null
10 } catch (error) {'ctx' is defined but never used
4
5import { type TServiceModalSchema } from './query.serviceModal.schema'
6
7const serviceModal = async ({ ctx, input }: TRPCHandlerParams<TServiceModalSchema>) => { 8 try {
9 return null
10 } catch (error) {'categoryRenderVariant' is assigned a value but never used
66
67const groupByCategory = (result: DatabaseResult) => {
68 const grouped = result.reduce<GroupedResult[]>((prev, curr) => {
69 const { categoryIcon, categoryId, categoryTag, categoryRenderVariant, ...attribute } = curr70 const existingIdx = prev.findIndex(({ id }) => id === categoryId)
71 if (existingIdx < 0) {
72 return ['categoryTag' is assigned a value but never used
66
67const groupByCategory = (result: DatabaseResult) => {
68 const grouped = result.reduce<GroupedResult[]>((prev, curr) => {
69 const { categoryIcon, categoryId, categoryTag, categoryRenderVariant, ...attribute } = curr70 const existingIdx = prev.findIndex(({ id }) => id === categoryId)
71 if (existingIdx < 0) {
72 return [
Description
Unused variables are generally considered a code smell and should be avoided.
Removing unused references - It prevents unused modules from being loaded at runtime, improving performance, and preventing the compiler from loading metadata that will never be used. - It prevents conflicts that may occur when trying to reference another variable.
NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _ to prevent them from being flagged by DeepSource.
Bad Practice
import fs from 'fs' // <- unused
import { readFileSync } from 'fs'
const text = readFileSync('declaration_of_independence.txt', 'utf-8')
console.log(text)
Recommended
import { readFileSync } from 'fs'
const text = readFileSync('declaration_of_independence.txt', 'utf-8')
console.log(text)