Exception caught is very general PYL-W0703
Anti-pattern
Major
4 years ago
—
5 years old
Catching too general exception Exception
319 exc_info=(exc_type, value, tb),
320 extra_data={"app": env.APP}
321 )
322 except Exception as e:323 logger.exception('reporting to rollbar: %s' % e)
324
325 sys.excepthook = report_exceptionCatching too general exception Exception
435 try:
436 locale.setlocale(locale.LC_ALL, 'en_US.UTF-8')
437 UNICODE_UPGRADED = True
438 except StandardError:439 UNICODE_LOCALE = False
440
441
Description
If the except block catches a very general exception, it is likely to catch any unrelated errors too. Try to be more explicit about which exception(s) you're trying to catch.
If you need to catch every other exception, then mark it as intentional by
adding a # skipcq comment.
Bad practice
try:
x = a / b
except Exception:
x = a / (b + 1)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except BaseException:
print('Only use numbers for the input')
Preferred:
try:
x = a / b
except ZeroDivisionError:
x = a / (b + 1)
try:
event_loop.run()
except Exception as exc: # skipcq: PYL-W0703 - Loop can sometimes crash.
sentry.report(exc)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except ValueError:
print('Only use numbers for the input')