Consider iterating dictionary PYL-C0201
Anti-pattern
Major
3 months ago
—
3 months old
Consider iterating the dictionary directly instead of calling .keys()
408 for key in self.widgets.keys():
409 self.widgets[key].configure(font=kwargs.pop("font"))
410
411 for key in self.widgets.keys():412 self.widgets[key].configure(**kwargs)
Consider iterating the dictionary directly instead of calling .keys()
405 self.widgets[key].configure(fg_color=kwargs.pop("button_color"))
406
407 if "font" in kwargs:
408 for key in self.widgets.keys():409 self.widgets[key].configure(font=kwargs.pop("font"))
410
411 for key in self.widgets.keys():Consider iterating the dictionary directly instead of calling .keys()
401 i += 1
402
403 if "button_color" in kwargs:
404 for key in self.widgets.keys():405 self.widgets[key].configure(fg_color=kwargs.pop("button_color"))
406
407 if "font" in kwargs:Consider iterating the dictionary directly instead of calling .keys()
396 )
397 if self.image_values is not None:
398 i = 0
399 for key in self.widgets.keys():400 self.widgets[key].configure(image=self.image_values[i])
401 i += 1
402Consider iterating the dictionary directly instead of calling .keys()
383 self.values = kwargs.pop("values")
384 self.image_values = None
385 self.button_num = len(self.values)
386 for key in self.widgets.keys():387 self.widgets[key].destroy()
388 self._init_buttons()
389
Description
Consider iterating the dictionary directly instead of calling .keys().
Using for key in dictionary would always iterate the dictionary keys.
Bad practice
sounds = {"cow": "moo", "dog": "bark"}
for key in sounds.keys():
print(key)
Recommended
sounds = {"cow": "moo", "dog": "bark"}
for key in sounds:
print(key)