if statements can be merged PTC-W0048
Anti-pattern
Major
3 months ago
—
3 months old
Consider merging collapsible if statements
57 val = data[key]
58 if val is None:
59 continue
60 if key in lookup: 61 if data[key] is not None:
62 val = (
63 data[key]Consider merging collapsible if statements
60 if d[key] not in vals:
61 vals.append(d[key])
62 print("EXTRA %s" % (key.upper(),), vals)
63 if len(vals) < 4:64 if input("DELETE? y/n ") == "y":
65 print("Deleting...")
66 worksheet.del_column(key.upper())Consider merging collapsible if statements
63 vals.append(d[key])
64 print("EXTRA %s[%s]" % (varname, soilcode))
65 print(vals)
66 if len(vals) < 4:67 if input("DELETE? y/n ") == "y":
68 print("Deleting... |%s|" % (varname,))
69 worksheet.del_column(varname)Consider merging collapsible if statements
68 if d[key] not in vals:
69 vals.append(d[key])
70 print("EXTRA %s" % (varname,), vals)
71 if len(vals) < 4:72 if input("DELETE? y/n ") == "y":
73 print("Deleting...")
74 worksheet.del_column(varname, sloppy=True)
Description
Nested if statements can be collapsed into a single if statement by separating their condition using and operator.
Merging collapsible if statements increases the code's readability.
Bad practice
if condition1:
if condition2:
dosomething()
Preferred
if condition1 and condition2:
dosomething()
Exception:
DeepSource will not raise this issue when the nested if statements have comments in between them, as it could be explaining why the nested if is in place.