Unnecessary
None provided as default PTC-W0039
Anti-pattern
Minor
3 months ago
—
3 months old
None as default value is redundant147 ("h_soil_nitrate %s[%s] unknown sample date %s")
148 % (siteid, YEAR, repr(colheading))
149 )
150 date = DUMMY_DATES.get(datetest, None)151 if date is None and row == 3:
152 print(
153 (None as default value is redundant204 <thead><tr><th width="33%%">Variable</th><th width="66%%">%s</th></tr>
205 """ % (ALL,)
206 for datavar in dvars:
207 row = data[ALL].get(datavar, None)208 payload += ("<tr><th>%s %s</th><td>%s</td></tr>") % (
209 datavar,
210 varlookup[datavar],None as default value is redundant187 for sid in sites:
188 payload += """<tr><th>%s</th>""" % (sid,)
189 for datavar in dvars:
190 row = data[sid].get(datavar, None)191 payload += f"<td>{make_progress(row)}</td>"
192 payload += "</tr>\n\n"
193 payload += "</table>"
Description
It is unnecessary to provide None as the default value when the key is not present in the dictionary as get implicitly returns None.
Not preferred:
value = some_dict.get("key", None)
Preferred:
value = some_dict.get("key")