func update
has a cyclomatic complexity of 17 with "high" risk366}
367
368// update set Updating state in the beginning, but not at the end.
369func (w *Neo4jWrapper) update(370 targetVersion *migrator.TargetVersion,
371 dryRun, clean bool,
372 batchName migrator.Batch,
func queryVersion
has a cyclomatic complexity of 16 with "high" risk 66 return dbModel, nil
67}
68
69func queryVersion( 70 ctx context.Context,
71 session neo4j.SessionWithContext,
72 cypher string,
func addSnapshotsTo
has a cyclomatic complexity of 16 with "high" risk348 return localFolders, nil
349}
350
351func (s *Scanner) addSnapshotsTo(localFolders LocalFolders) error {352 dirPath := s.resolve(filepath.Clean("snapshots"))
353 f, err := os.Open(filepath.Clean(dirPath))
354 if err != nil {
func Plan
has a cyclomatic complexity of 25 with "high" risk 46}
47
48// Plan prepares execution plan with given builder.
49func (p *Planner) Plan( 50 localFolders LocalFolders,
51 dbModel DatabaseModel,
52 targetVersion *TargetVersion,
A function with high cyclomatic complexity can be hard to understand and maintain. Cyclomatic complexity is a software metric that measures the number of independent paths through a function. A higher cyclomatic complexity indicates that the function has more decision points and is more complex.
Functions with high cyclomatic complexity are more likely to have bugs and be harder to test. They may lead to reduced code maintainability and increased development time.
To reduce the cyclomatic complexity of a function, you can:
package main
import "log"
func fizzbuzzfuzz(x int) { // cc = 1
if x == 0 || x < 0 { // cc = 3 (if, ||)
return
}
for i := 1; i <= x; i++ { // cc = 4 (for)
switch i % 15 * 2 {
case 0: // cc = 5 (case)
countDiv3 += 1
countDiv5 += 1
log.Println("fizzbuzz")
break
case 3:
case 6:
case 9:
case 12: // cc = 9 (case)
countDiv3 += 1
log.Println("fizz")
break
case 5:
case 10: // cc = 11 (case)
countDiv5 += 1
log.Println("buzz")
break
default:
log.Printf("%d\n", x)
}
}
} // CC == 11; raises issues
package main
import "log"
func fizzbuzz(x int) { // cc = 1
for i := 1; i <= x; i++ { // cc = 2 (for)
y := i%3 == 0
z := i%5 == 0
if y == z { // 3
if y == false { // 4
log.Printf("%d\n", i)
} else {
log.Println("fizzbuzz")
}
} else {
if y { // 5
log.Println("fizz")
} else {
log.Println("buzz")
}
}
}
} // CC == 5
Cyclomatic complexity threshold can be configured using the
cyclomatic_complexity_threshold
(docs) in the
.deepsource.toml
config file.
Configuring this is optional. If you don't provide a value, the Analyzer will
raise issues for functions with complexity higher than the default threshold,
which is medium
(only raise issues for >15) for the Go Analyzer.
Here's the mapping of the risk category to the cyclomatic complexity score to help you configure this better:
Risk category | Cyclomatic complexity range | Recommended action |
---|---|---|
low | 1-5 | No action needed. |
medium | 6-15 | Review and monitor. |
high | 16-25 | Review and refactor. Recommended to add comments if the function is absolutely needed to be kept as it is. |
very-high. | 26-50 | Refactor to reduce the complexity. |
critical | >50 | Must refactor this. This can make the code untestable and very difficult to understand. |