Detected unnecessary constructors JS-0358
Anti-pattern
Minor
2 months ago
—
3 months old
Useless constructor
4import { logger } from "@homarr/log";
5
6class LoggingAgent extends Agent {
7 constructor(...props: ConstructorParameters<typeof Agent>) { 8 super(...props); 9 }10
11 dispatch(options: Dispatcher.DispatchOptions, handler: Dispatcher.DispatchHandlers): boolean {
12 logger.info(Useless constructor
4import { logger } from "@homarr/log";
5
6class LoggingAgent extends Agent {
7 constructor(...props: ConstructorParameters<typeof Agent>) { 8 super(...props); 9 }10
11 dispatch(options: Dispatcher.DispatchOptions, handler: Dispatcher.DispatchHandlers): boolean {
12 logger.info(Useless constructor
4import { logger } from "@homarr/log";
5
6class LoggingAgent extends Agent {
7 constructor(...props: ConstructorParameters<typeof Agent>) { 8 super(...props); 9 }10
11 dispatch(options: Dispatcher.DispatchOptions, handler: Dispatcher.DispatchHandlers): boolean {
12 logger.info(Useless constructor
4import { logger } from "@homarr/log";
5
6class LoggingAgent extends Agent {
7 constructor(...props: ConstructorParameters<typeof Agent>) { 8 super(...props); 9 }10
11 dispatch(options: Dispatcher.DispatchOptions, handler: Dispatcher.DispatchHandlers): boolean {
12 logger.info(Useless constructor
4import { logger } from "@homarr/log";
5
6class LoggingAgent extends Agent {
7 constructor(...props: ConstructorParameters<typeof Agent>) { 8 super(...props); 9 }10
11 dispatch(options: Dispatcher.DispatchOptions, handler: Dispatcher.DispatchHandlers): boolean {
12 logger.info(
Description
ES2015 provides a default class constructor if one isn't explicitly specified. As such, it is unnecessary to provide an empty constructor or one that simply delegates into its parent class.
Bad Practice
class Animal {
constructor () {}
}
class Dog extends Animal {
constructor() { super() }
bark() { /* code */ }
}
Recommended
class Animal {}; // empty abstract class
class Dog extends Animal {
bark() { /* code */ }
};