Unused parameter in function RVV-B0012
Bug risk
Minor
8 days ago
—
3 years old
parameter 'sqlConfig' seems to be unused, consider removing or renaming it as _
210}
211
212// MigrateWordfilters migrates pre-filter wordfilters to the filter table
213func MigrateWordfilters(ctx context.Context, db *gcsql.GCDB, tx *sql.Tx, sqlConfig *config.SQLConfig) error {214 rows, err := db.QueryContextSQL(ctx, nil, `SELECT board_dirs, staff_id, staff_note, issued_at, search, match_mode, change_to FROM DBPREFIXwordfilters`)
215 if err != nil {
216 return errparameter 'cfg' seems to be unused, consider removing or renaming it as _
157}
158
159// MigrateUsernameBans migrates poster name bans to the filter table
160func MigrateUsernameBans(ctx context.Context, db *gcsql.GCDB, tx *sql.Tx, cfg *config.SQLConfig) error {161 rows, err := db.QueryContextSQL(ctx, nil, `SELECT board_id,staff_id,staff_note,issued_at,username,is_regex FROM DBPREFIXusername_ban`)
162 if err != nil {
163 return errparameter 'cfg' seems to be unused, consider removing or renaming it as _
105}
106
107// MigrateFilenameBans migrates filename bans to the filter table
108func MigrateFilenameBans(ctx context.Context, db *gcsql.GCDB, tx *sql.Tx, cfg *config.SQLConfig) error {109 rows, err := db.QueryContextSQL(ctx, nil, `SELECT board_id,staff_id,staff_note,issued_at,filename,match_mode FROM DBPREFIXfilename_ban`)
110 if err != nil {
111 return errparameter 'cfg' seems to be unused, consider removing or renaming it as _
38}
39
40// MigrateFileBans migrates file checksum and image fingerprint bans to the filter table
41func MigrateFileBans(ctx context.Context, db *gcsql.GCDB, tx *sql.Tx, cfg *config.SQLConfig) error { 42 rows, err := db.QueryContextSQL(ctx, nil, `SELECT board_id,staff_id,staff_note,issued_at,checksum,fingerprinter,ban_ip,ban_ip_message FROM DBPREFIXfile_ban`)
43 if err != nil {
44 return errparameter 'p' seems to be unused, consider removing or renaming it as _
216 },
217 "useragent": &conditionHandler{
218 fieldType: StringField,
219 matchFunc: func(r *http.Request, p *Post, _ *Upload, fc *FilterCondition) (bool, error) {220 return matchString(fc, r.UserAgent())
221 },
222 },
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}