Found redundant literal in a logical expression JS-W1043
Anti-pattern
Minor
8 months ago
—
a year old
Logical expression with a literal operand will always evaluate to the same value
103
104 db.sequelize.sync();
105 // set port, listen for requests
106 const PORT = global.env.PORT || 8080;107 app.listen(PORT, () => {
108 console.log(`Server is running on port ${PORT}.`);
109 });Logical expression with a literal operand will always evaluate to the same value
138 if (error.name === "TokenExpiredError") {
139 return res
140 .status(400)
141 .send({ message: error.message || "Güvenlik kodu süresü doldu." });142 }
143 console.log(error);
144 res.status(500).send({ message: "Failed to reset password" });Logical expression with a literal operand will always evaluate to the same value
102 console.log(error);
103 return res
104 .status(500)
105 .send({ message: error.message || "Failed to send email" });106 }
107 console.log("Email sent: " + info.response);
108 res.status(200).send({ message: "Password reset email sent" });Logical expression with a literal operand will always evaluate to the same value
26 })
27 .catch((err) => {
28 res.status(500).send({
29 message: err.message || "Some error occurred while retrieving users.", 30 });
31 });
32};Logical expression with a literal operand will always evaluate to the same value
21 })
22 .catch((err) => {
23 res.status(500).send({
24 message: err.message || "Some error occurred while retrieving rapors.",25 });
26 });
27};
Description
Expressions that consistently result in either true or false when comparing values, and logical operations like ||, &&, and ?? that consistently either skip or fully evaluate their operands, often indicate mistakes. Logical operations that always yield the same result could lead to unexpected behavior or bugs in the program.
Bad Practice
const arrIsEmpty = someArr === [] // Will always evaluate to false
Recommended
const arrIsEmpty = someArr.length === 0