Use
const declarations for variables that are never reassigned JS-0242
Anti-pattern
Minor
10 months ago
—
3 years old
'forDeletion' is never reassigned. Use 'const' instead
1323exports.update = (req, res) => {
1324 const id = req.autosan.params.id;
1325 var fields = Object.keys(req.body);
1326 let forDeletion = ["id"];1327 fields = fields.filter((item) => !forDeletion.includes(item));
1328 if (req.body["x"] !== null && req.body["y"] !== null) {
1329 var check = checkPointInPolygon(req.body["lat"], req.body["lon"]);'data' is never reassigned. Use 'const' instead
161};
162
163const importData = (element, user) => {
164 let data = {};165 Object.entries(element).forEach(([key, value], index) => {
166 data[fileHeader[index]] = value;
167'secureEnv' is never reassigned. Use 'const' instead
4const cookieParser = require("cookie-parser");
5const session = require("express-session");
6const compression = require("compression");
7let secureEnv = require("secure-env"); 8global.__basedir = __dirname + "/..";
9global.env = secureEnv({ secret: "mySecretPassword" });
10const cluster = require("cluster");'refreshToken' is never reassigned. Use 'const' instead
18
19 let _token = uuidv4();
20
21 let refreshToken = await this.create({22 token: _token,
23 userId: user.id,
24 expiryDate: expiredAt.getTime(),'_token' is never reassigned. Use 'const' instead
16
17 expiredAt.setSeconds(expiredAt.getSeconds() + config.jwtRefreshExpiration);
18
19 let _token = uuidv4();20
21 let refreshToken = await this.create({
22 token: _token,
Description
Variables that are never re-assigned a new value after their initial declaration should be declared with the const keyword.
This prevents the programmer from erroneously re-assigning to a read-only variable, and informs those reading the code that a variable is a constant value.
Bad Practice
let pi = Math.PI
for (let x of xs) {
use(x);
}
let { a, b } = object;
use(a, b);
Recommended
const pi = Math.PI
for (const x of xs) {
use(x);
}
const { a, b } = object;
use(a, b);