Invalid variable usage JS-0043
Anti-pattern
Critical
3 months ago
—
3 years old
'check' used outside of binding context
1423 req.body["yuzbin"] = check.yuz.join(", ");
1424 req.body["besyuzbin"] = check.besyuz.join(", ");
1425 req.body["il"] = check.il.join(", ");
1426 req.body["ilce"] = check.ilce.join(", ");1427 }
1428
1429 Tutorial.update(req.body, {'check' used outside of binding context
1422 req.body["yirmibesbin"] = check.yirmibes.join(", ");
1423 req.body["yuzbin"] = check.yuz.join(", ");
1424 req.body["besyuzbin"] = check.besyuz.join(", ");
1425 req.body["il"] = check.il.join(", ");1426 req.body["ilce"] = check.ilce.join(", ");
1427 }
1428'check' used outside of binding context
1421 //join array elements with whitespace and comma
1422 req.body["yirmibesbin"] = check.yirmibes.join(", ");
1423 req.body["yuzbin"] = check.yuz.join(", ");
1424 req.body["besyuzbin"] = check.besyuz.join(", ");1425 req.body["il"] = check.il.join(", ");
1426 req.body["ilce"] = check.ilce.join(", ");
1427 }'check' used outside of binding context
1420 var check = intersectionCheck(geoJson);
1421 //join array elements with whitespace and comma
1422 req.body["yirmibesbin"] = check.yirmibes.join(", ");
1423 req.body["yuzbin"] = check.yuz.join(", ");1424 req.body["besyuzbin"] = check.besyuz.join(", ");
1425 req.body["il"] = check.il.join(", ");
1426 req.body["ilce"] = check.ilce.join(", ");'check' used outside of binding context
1419 };
1420 var check = intersectionCheck(geoJson);
1421 //join array elements with whitespace and comma
1422 req.body["yirmibesbin"] = check.yirmibes.join(", ");1423 req.body["yuzbin"] = check.yuz.join(", ");
1424 req.body["besyuzbin"] = check.besyuz.join(", ");
1425 req.body["il"] = check.il.join(", ");
Description
Variables should be used inside of their binding context.
This helps avoid difficult bugs with variable hoisting.
It is a bad practice to use var declarations because variables declared using var can be accessed in a function-wide scope.
They can even be accessed before declaration.
In such cases, their value would be undefined because only declarations and not initializations are hoisted.
Bad Practice
function doIf() {
if (cond()) {
var build = true;
}
console.log(build);
}
function doIfElse() {
if (cond()) {
var build = true;
} else {
var build = false;
}
console.log(build)
}
Recommended
function doIf() {
let build;
if (cond()) {
build = true;
}
console.log(build);
}