Found empty functions JS-0057
Anti-pattern
Minor
11 days ago
—
11 days old
Unexpected empty arrow function
81 VulnerabilityType.create({
82 locale: d.locale,
83 name: d.vulnType,
84 }).catch(e => {}); 85 }
86 if (d.description) details.description = d.description;
87 if (d.observation) details.observation = d.observation;Unexpected empty arrow function
66 vuln.remediationComplexity = req.body[i].remediationComplexity;
67 if (req.body[i].category) {
68 vuln.category = req.body[i].category;
69 VulnerabilityCategory.create({ name: vuln.category }).catch(e => {}); 70 }
71 vuln.details = [];
72 req.body[i].details.forEach(d => {Unexpected empty function 'apply'
1var expressions = require('angular-expressions');
2
3// Apply all customs functions
4function apply(data) {} 5exports.apply = apply;
6
7// *** Custom modifications of audit data for usage in word template
Description
Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.
Bad Practice
getUser('SwaGaLisTiQuE', () => {})
function f() {}
Recommended
getUser('SwaGaLisTiQuE', () => {
// empty because <reason>
})
function f() {
// intentionally empty. <reason>
}