Positional arguments are out of order PYL-W1114
Style
Minor
2 months ago
—
2 months old
Positional arguments appear to be out of order
33
34 def lev_dist(self, s1, s2):
35 if len(s1) < len(s2):
36 return self.lev_dist(s2, s1) 37
38 if len(s2) == 0:
39 return len(s1)
Description
Positional arguments (with the same name as function parameters) appear to be out of order. Ensure that the order of arguments passed is correct.
Bad practice
def func_with_two_args(arg_one, arg_two):
...
arg_one = 1
arg_two = 2
func_with_two_args(arg_two, arg_one)
Recommended
def func_with_two_args(arg_one, arg_two):
...
arg_one = 1
arg_two = 2
func_with_two_args(arg_one, arg_two)