Found empty block statements JS-0009
Anti-pattern
Minor
8 months ago
—
a year old
Empty block statement
17 // Set future value
18 try {
19 dataStore.setItem(index, newIndex);
20 } catch (e) { }21 }
22 }).addClass("ui-tabs-vertical ui-helper-clearfix");
23 $("#tabs li").removeClass("ui-corner-top").addClass("ui-corner-left");Empty block statement
7 try {
8 // getter: Fetch previous value
9 oldIndex = dataStore.getItem(index);
10 } catch (e) { }11
12 $("#tabs").tabs({
13 active: oldIndex,Empty block statement
17730 var pow2,
17731 bounce = 4;
17732
17733 while ( p < ( ( pow2 = Math.pow( 2, --bounce ) ) - 1 ) / 11 ) {}17734 return 1 / Math.pow( 4, 3 - bounce ) - 7.5625 * Math.pow( ( pow2 * 3 - 2 ) / 22 - p, 2 );
17735 }
17736} );Empty block statement
16759 try {
16760 backgroundColor = jQuery.css( curElem, "backgroundColor" );
16761 curElem = curElem.parentNode;
16762 } catch ( e ) {16763 }16764 }
16765
16766 value = value.blend( backgroundColor && backgroundColor !== "transparent" ?Empty block statement
14777 } catch ( error ) {}
14778 try {
14779 locationUrl = decodeURIComponent( locationUrl );
14780 } catch ( error ) {}14781
14782 return anchor.hash.length > 1 && anchorUrl === locationUrl;
14783 };
Description
Empty block statements, while not technically errors, usually occur due to refactoring that wasn't completed. They can mislead the reader.
If you still want to keep an empty block, add a comment saying empty inside the block.
Bad Practice
if (someCheck) {}
while (someCheck) {}
try {
doSomething();
} catch(err) {
} finally {
}
Recommended
if (someCheck) {
// empty
}
while (someCheck) {
/* empty */
}
try {
doSomething();
} catch (err) {
// continue regardless of error
}
try {
doSomething();
} finally {
/* continue regardless of error */
}