else
/ elif
used after return
PYL-R170514 return private_key, public_key
15
16 def perform_operation(self, operation, params):
17 if operation == "add":18 point1 = self.decode_point(params["point1"])
19 point2 = self.decode_point(params["point2"])
20 result = point1 + point2
42
43 # Check if the combined hash meets the target difficulty
44 target_difficulty = self.blockchain.target_difficulty
45 if int(combined_hash, 16) < target_difficulty:46 return True
47 else:
48 return False
The use of else
or elif
becomes redundant and can be dropped if the last statement under the leading if
/ elif
block is a return
statement.
In the case of an elif
after return
, it can be written as a separate if
block.
For else
blocks after return
, the statements can be shifted out of else
. Please refer to the examples below for reference.
Refactoring the code this way can improve code-readability and make it easier to maintain.
def classify_number(x):
if x % 2 == 0:
return 'Even'
else:
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
elif x % 2 == 0 and x < 0:
return 'Even and Negative'
elif x % 2 != 0 and x < 0:
return 'Odd and Negative.'
else:
return 'Odd'
def classify_number(x):
if x % 2 == 0:
return 'Even'
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
if x % 2 == 0 and x < 0:
return 'Even and Negative'
if x % 2 != 0 and x < 0:
return 'Odd and Negative'
return 'Odd'