Consider merging
isinstance calls PYL-R1701
Anti-pattern
Major
4 months ago
—
4 months old
Consider merging these isinstance calls to isinstance(module, (torch.nn.Conv2d, torch.nn.Linear))
8
9def model_pruning(model, amount=0.2):
10 for name, module in model.named_modules():
11 if isinstance(module, torch.nn.Conv2d) or isinstance(module, torch.nn.Linear):12 weight_copy = module.weight.data.abs().clone()
13 _, idx = torch.sort(weight_copy)
14 _, mask = torch.sort(idx, descending=True)
Description
You can pass a tuple of types you want to check as the second argument to isinstance.
If the object matches with any of the types, it will return True else False.
It is therefore recommended to merge multiple consecutive isinstance calls into one. It is clearer and improves readability.
# Instead of
if isinstance(i, int) or isinstance(i, float):
print('A number')
# Do this
if isinstance(i, (int, float)):
print('A number')