Detected unnecessary constructors JS-0358
Anti-pattern
Minor
15 days ago
—
3 years old
Useless constructor
28} from "@/app/core/init";
29
30export default class LoadUtils {
31 constructor() {} 32
33 static loadFromScratch(json: InterchangeV1_2): [Device, Array<RenderLayer>] {
34 const newDevice: Device = LoadUtils.loadDeviceFromInterchangeV1_2(json);Useless constructor
2import { ComponentAPI } from "@/componentAPI";
3
4export default class ConnectionUtils {
5 constructor() {} 6
7
8 static getDefinition(stringname: string) {Useless constructor
2import { ComponentAPI } from "@/componentAPI";
3
4export default class ComponentUtils {
5 constructor() {} 6
7 static getFeatureFromID(featureid: string) {
8 return Registry.currentDevice!.getFeatureByID(featureid);Useless constructor
5import { CompoundPath } from "paper/dist/paper-core";
6
7export default class YTree extends Template {
8 constructor() { 9 super(); 10 } 11
12 __setupDefinitions(): void {
13 this.__unique = {Useless constructor
4import { LogicalLayerType } from "../core/init";
5
6export default class Via extends Template {
7 constructor() { 8 super(); 9 } 10
11 __setupDefinitions(): void {
12 this.__unique = {
Description
ES2015 provides a default class constructor if one isn't explicitly specified. As such, it is unnecessary to provide an empty constructor or one that simply delegates into its parent class.
Bad Practice
class Animal {
constructor () {}
}
class Dog extends Animal {
constructor() { super() }
bark() { /* code */ }
}
Recommended
class Animal {}; // empty abstract class
class Dog extends Animal {
bark() { /* code */ }
};