Found unused variables in TypeScript code JS-0356
Performance
Major
15 days ago
—
3 years old
'next' is defined but never used
36router.use("/", routes);
37
38/** Error handling */
39router.use((req, res, next) => {40 const error = new Error("not found");
41 return res.status(404).json({
42 message: error.message'next' is defined but never used
2import controller from "./controller";
3const router = express.Router();
4
5router.get("/", (req, res, next) => { 6 return res.status(200).json({
7 message: "Welcome to the Component API"
8 });'next' is defined but never used
58 res.send(ret);
59};
60
61const getDefaults = async (req: Request, res: Response, next: NextFunction) => {62 console.log(req.query, req.query.mint, req.query["mint"]);
63 let primitive = req.query.mint;
64 let key = primitive as string;'next' is defined but never used
27 return res.send({"x-span":ret.xspan, "y-span":ret.yspan});
28};
29
30const getTerminals = async (req: Request, res: Response, next: NextFunction) => {31 let primitive = req.query.mint;
32 let key = primitive as string;
33 let technology = ComponentAPI.getComponentWithMINT(key);'next' is defined but never used
5
6paper.setup(new paper.Size([64000, 48000]));
7
8const getDimensions = async (req: Request, res: Response, next: NextFunction) => { 9 let primitive = req.query.mint;
10 let key = primitive as string;
11 let technology = ComponentAPI.getComponentWithMINT(key);
Description
Unused variables are generally considered a code smell and should be avoided.
Removing unused references - It prevents unused modules from being loaded at runtime, improving performance, and preventing the compiler from loading metadata that will never be used. - It prevents conflicts that may occur when trying to reference another variable.
NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _ to prevent them from being flagged by DeepSource.
Bad Practice
import fs from 'fs' // <- unused
import { readFileSync } from 'fs'
const text = readFileSync('declaration_of_independence.txt', 'utf-8')
console.log(text)
Recommended
import { readFileSync } from 'fs'
const text = readFileSync('declaration_of_independence.txt', 'utf-8')
console.log(text)