Getter without a setter pair in objects JS-0041
Anti-pattern
Minor
15 days ago
—
3 years old
Getter is not present for class setter 'nameMap'
93 * @param {Map<string, number>}
94 * @memberof Device
95 */
96 set nameMap(nameMap: Map<string, number>) { 97 this.__nameMap = nameMap;
98 }
99Getter is not present for class setter 'renderData'
62 * @memberof CustomComponent
63 * @returns {void}
64 */
65 set renderData(data: any) { 66 this._renderData = data;
67 }
68
Description
It's a common mistake in JavaScript to create an object with just a setter for a property but never have a corresponding getter defined for it. Without a getter, you cannot read the property, so it ends up not being used.
Bad Practice
const o = {
set a(value) {
this.val = value;
}
};
// or
const o = {d: 1};
Object.defineProperty(o, 'c', {
set: function(value) {
this.val = value;
}
});
Recommended
const o = {
set a(value) {
this.val = value;
},
get a() {
return this.val;
}
};
const o = {d: 1};
Object.defineProperty(o, 'c', {
set: function(value) {
this.val = value;
},
get: function() {
return this.val;
}
});