Methods must not be empty JAVA-W1004
Anti-pattern
Minor
a year ago
—
2 years old
paintIcon should not be empty
11 class ShapeIcon implements Icon {
12
13 @Override
14 public void paintIcon(Component c, Graphics g, int x, int y) {15 }16
17 @Override
18 public int getIconWidth() {
Description
This method is empty and does not appear to have any explanation regarding why. This may confuse future readers of this code. Additionally, such code produces needless, avoidable clutter.
Bad Practice
void method() {
}
Recommended
If the method overrides a parent implementation and is left empty to prevent default behavior, consider documenting why with a comment:
@Override
void method() {
// left empty because of ...
}