Invalid variable usage JS-0043
Anti-pattern
Critical
5 months ago
—
2 years old
'i' used outside of binding context
11239 i.push(d);
11240 }
11241 }
11242 return i;11243 }),
11244 (q.fn.clearForm = function (e) {
11245 return this.each(function () {'t' used outside of binding context
11198 (o.constructor === Array && !o.length) ||
11199 (o.constructor === Array ? q.merge(t, o) : t.push(o));
11200 }
11201 return t;11202 }),
11203 (q.fieldValue = function (e, t) {
11204 var r = e.name,'r' used outside of binding context
10733 var o = n.beforeSend;
10734 return (
10735 (n.beforeSend = function (e, t) {
10736 M.formData ? (t.data = M.formData) : (t.data = r),10737 o && o.call(this, e, t);
10738 }),
10739 q.ajax(n)'t' used outside of binding context
10700 return o;
10701 })(M.extraData);
10702 for (t = 0; t < a.length; t++)
10703 a[t] && r.append(a[t][0], a[t][1]);10704 }
10705 M.data = null;
10706 var n = q.extend(!0, {}, q.ajaxSettings, M, {'r' used outside of binding context
10700 return o;
10701 })(M.extraData);
10702 for (t = 0; t < a.length; t++)
10703 a[t] && r.append(a[t][0], a[t][1]);10704 }
10705 M.data = null;
10706 var n = q.extend(!0, {}, q.ajaxSettings, M, {
Description
Variables should be used inside of their binding context.
This helps avoid difficult bugs with variable hoisting.
It is a bad practice to use var declarations because variables declared using var can be accessed in a function-wide scope.
They can even be accessed before declaration.
In such cases, their value would be undefined because only declarations and not initializations are hoisted.
Bad Practice
function doIf() {
if (cond()) {
var build = true;
}
console.log(build);
}
function doIfElse() {
if (cond()) {
var build = true;
} else {
var build = false;
}
console.log(build)
}
Recommended
function doIf() {
let build;
if (cond()) {
build = true;
}
console.log(build);
}