Use shorthand property syntax for object literals JS-0240
Anti-pattern
Minor
11 days ago
—
a year old
Expected property shorthand
132 }),
133 number: number,
134 incompatible: incompatible,
135 accessInstructions: accessInstructions,136}
137
138export type AttributeSupplementSchemas = keyof typeof AttSuppSchemasExpected property shorthand
131 message: 'Requires at least `min` or `max`.',
132 }),
133 number: number,
134 incompatible: incompatible,135 accessInstructions: accessInstructions,
136}
137Expected property shorthand
130 numMinMaxOpt: numMinMaxOpt.refine(({ min, max }) => Boolean(min || max), {
131 message: 'Requires at least `min` or `max`.',
132 }),
133 number: number,134 incompatible: incompatible,
135 accessInstructions: accessInstructions,
136}Expected property shorthand
126export const AttSuppSchemas = {
127 numMinMax: numMinMax,
128 numMin: numMin,
129 numMax: numMax,130 numMinMaxOpt: numMinMaxOpt.refine(({ min, max }) => Boolean(min || max), {
131 message: 'Requires at least `min` or `max`.',
132 }),Expected property shorthand
125
126export const AttSuppSchemas = {
127 numMinMax: numMinMax,
128 numMin: numMin,129 numMax: numMax,
130 numMinMaxOpt: numMinMaxOpt.refine(({ min, max }) => Boolean(min || max), {
131 message: 'Requires at least `min` or `max`.',
Description
ECMAScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.
Here are a few common examples using the ES5 syntax:
const x = 1, y = 2, z = 3;
// properties
const foo = {
x: x,
y: y,
z: z,
};
// methods
const foo = {
a: function() {},
b: function() {}
};
The ES6 equivalent syntax is::
// properties
const foo = {x, y, z};
// methods
const bar = {
a() { return 1 },
b() { return 2 }
};
NOTE: The shorthand properties are equivalent to function expressions.
Meaning that they do not bind their own this inside their bodies.
It is still possible to access properties from the object inside a shorthand member function:
const object = {
x: 1,
getX() {
return this.x // valid
}
}
Bad Practice
const foo = {
bar: function () { return 1 }
};
Recommended
const foo = {
bar() { return 1 }
}