Redefinition of builtin RVV-B0009
Bug risk
Major
7 months ago
—
2 years old
redefinition of the built-in function new
321 for _, id := range s.conf.EvictedStores {
322 old[id] = struct{}{}
323 }
324 new := make(map[uint64]struct{})325 for _, id := range newCfg.EvictedStores {
326 new[id] = struct{}{}
327 }redefinition of the built-in function new
222 for _, id := range s.conf.EvictedStores {
223 old[id] = struct{}{}
224 }
225 new := make(map[uint64]struct{})226 for _, id := range newCfg.EvictedStores {
227 new[id] = struct{}{}
228 }redefinition of the built-in function new
190 delete(intervalSums, ret.StoreID)
191 continue
192 }
193 new := int(ret.getIntervalSum() / 1000000000)194 if old, ok := intervalSums[ret.StoreID]; ok {
195 re.Equal((old+int(interval))%utils.RegionHeartBeatReportInterval, new)
196 }redefinition of the built-in function cap
118 s.LearnerCount += store.GetLearnerCount()
119 limit, ok := store.GetStoreLimit().(*storelimit.SlidingWindows)
120 if ok {
121 cap := limit.GetCap()122 storeStatusGauge.WithLabelValues(storeAddress, id, "windows_size").Set(float64(cap))
123 for i, use := range limit.GetUsed() {
124 priority := constant.PriorityLevel(i).String()redefinition of the built-in function cap
82 return
83 }
84 if cap < 0 {
85 cap = minSnapSize 86 }
87 for i, v := range s.windows {
88 v.reset(int64(cap) >> i)
Description
Constant names like false, true, nil and function names like append,
make, and basic type names like bool, and byte are not reserved keywords
of the language making them eligible for redefinition. It is not recommended to
redefine these builtins (or keywords) that can lead to bugs that are very
difficult to detect.
Bad practice
nil := true
Recommended
nilVal := true