Potentially unwanted dependency on evaluation order GO-W4006
Bug risk
Major
8 months ago
—
a year old
may want to evaluate region.GetStorePeer(source.GetID()) before the return statement
155 pendingFilter, downFilter, replicaFilter)
156 }
157 if region != nil {
158 return region, region.GetStorePeer(source.GetID())159 }
160 shuffleRegionNoRegionCounter.Inc()
161 }
Description
Depending on the evaluation order is not idiomatic and may lead to bugs during future refactorings.
Bad practice
package main
func mutate(x *int) int {
*x += 10
return *x
}
func identity(x int) int {
return x
}
func foo() (int, int, int) {
x := 5
return identity(x), mutate(&x), x // 5, 15, 15
}
Recommended
package main
func mutate(x *int) int {
*x += 10
return *x
}
func identity(x int) int {
return x
}
func foo() (int, int, int) {
x := 5
result := mutate(&x)
return identity(x), result, x // 15, 15, 15
}