Empty slice literal used to declare a variable GO-W1027
Anti-pattern
Minor
5 months ago
—
2 years old
Empty slice literal of type "[]testRegionInfo" used to define "regions"
1751 defer func() {
1752 statistics.ThresholdsUpdateInterval = 8 * time.Second
1753 }()
1754 regions := []testRegionInfo{}1755 for i := 1; i <= 500; i++ {
1756 regions = append(regions, testRegionInfo{
1757 id: uint64(i),Empty slice literal of type "[]testRegionInfo" used to define "regions"
1694 { // many regions
1695 cancel, _, tc, _ := prepareSchedulersTest()
1696 defer cancel()
1697 regions := []testRegionInfo{}1698 for i := 1; i <= 1000; i += 2 {
1699 regions = append(regions,
1700 testRegionInfo{Empty slice literal of type "[]string" used to define "args"
369 // enable `evict-slow-trend` scheduler as default.
370 if c.GetCluster().GetStoreConfig().IsRaftKV2() {
371 typ := schedulers.EvictSlowTrendType
372 args := []string{}373
374 s, err := schedulers.CreateScheduler(typ, c.opController, c.cluster.GetStorage(), schedulers.ConfigSliceDecoder(typ, args), c.schedulers.RemoveScheduler)
375 if err != nil {Empty slice literal of type "[]*etcdEvent" used to define "events"
1010 rootPath := mgr.legacySvcRootPath
1011 svcAddr := mgr.tsoServiceID.ServiceAddr
1012
1013 events := []*etcdEvent{}1014 // Split target keyspace group event arrives first.
1015 events = append(events, generateKeyspaceGroupPutEvent(2, []uint32{2} /* Mock 2 replicas */, []string{svcAddr, svcAddr}, &endpoint.SplitState{
1016 SplitSource: 1,Empty slice literal of type "[]uint32" used to define "ids"
907 kgm.RLock()
908 defer kgm.RUnlock()
909
910 ids := []uint32{} 911 for i := 0; i < len(kgm.kgs); i++ {
912 kg := kgm.kgs[i]
913 if kg != nil {
Description
An empty slice can be represented by nil or an empty slice literal. They are
functionally equivalent — their len and cap are both zero — but the nil
slice is the preferred style. For more information about empty slices,
see Declaring Empty Slices.
Bad practice
package main
func foo() {
a := []int{}
}
Recommended
package main
func foo() {
var a []int
}