http.NewRequest request send to http:// URLs GO-S1028Does not encrypt traffic with TLS, use HTTPS instead: http://127.0.0.1:2379/test?test=test
124 backend := NewLocalLogBackend(true)
125 fname := testutil.InitTempFileLogger("info")
126 defer os.RemoveAll(fname)
127 req, _ := http.NewRequest(http.MethodGet, "http://127.0.0.1:2379/test?test=test", strings.NewReader("testBody"))128 b.StartTimer()
129 for i := 0; i < b.N; i++ {
130 info := requestutil.GetRequestInfo(req)Does not encrypt traffic with TLS, use HTTPS instead: http://127.0.0.1:2379/test?test=test
110func BenchmarkLocalLogAuditUsingTerminal(b *testing.B) {
111 b.StopTimer()
112 backend := NewLocalLogBackend(true)
113 req, _ := http.NewRequest(http.MethodGet, "http://127.0.0.1:2379/test?test=test", strings.NewReader("testBody"))114 b.StartTimer()
115 for i := 0; i < b.N; i++ {
116 info := requestutil.GetRequestInfo(req)Does not encrypt traffic with TLS, use HTTPS instead: http://127.0.0.1:2379/test?test=test
92 backend := NewLocalLogBackend(true)
93 fname := testutil.InitTempFileLogger("info")
94 defer os.RemoveAll(fname)
95 req, _ := http.NewRequest(http.MethodGet, "http://127.0.0.1:2379/test?test=test", strings.NewReader("testBody")) 96 re.False(backend.ProcessHTTPRequest(req))
97 info := requestutil.GetRequestInfo(req)
98 req = req.WithContext(requestutil.WithRequestInfo(req.Context(), info))Does not encrypt traffic with TLS, use HTTPS instead: http://127.0.0.1:2379/test?test=test
57 defer ts.Close()
58
59 backend := NewPrometheusHistogramBackend(serviceAuditHistogramTest, true)
60 req, _ := http.NewRequest(http.MethodGet, "http://127.0.0.1:2379/test?test=test", http.NoBody) 61 info := requestutil.GetRequestInfo(req)
62 info.ServiceLabel = "test"
63 info.CallerID = "user1"
Description
Requests sent via http.NewRequest to http:// URLs is dangerous because the
server is attempting to connect to a website that does not encrypt traffic with
TLS. Instead, it is recommended to use https://.
Bad practice
req, err := http.NewRequest("GET", "http://deepsource.io", nil)
Recommended
req, err := http.NewRequest("GET", "https://deepsource.io", nil)