GO-R4001 · Use `http.NoBody` instead of `nil` in `http.NewRequest` calls

tikv / pd

Active

Use http.NoBody instead of nil in http.NewRequest calls GO-R4001

Anti-pattern

Major

a month ago — a year old

http.NoBody should be preferred to the nil request body

79		return ""
80	}
81
82	req, err := http.NewRequest(http.MethodGet, addr, nil)83	if err != nil {
84		return ""
85	}

Description

http.NoBody is an io.ReadCloser with no bytes. Read always returns EOF and Close always returns nil.

func foo(url string) {
  http.NewRequest("GET", url, nil)
}