Use
fmt.Fprint instead of (io.Writer).Write along with fmt.Sprint GO-P4007
Performance
Major
8 months ago
—
10 months old
fmt.Fprintf(res, "failed setting up test server: %s", err) should be preferred to the res.Write([]byte(fmt.Sprintf("failed setting up test server: %s", err)))
1429 b, err := json.Marshal(cfg)
1430 if err != nil {
1431 res.WriteHeader(http.StatusInternalServerError)
1432 res.Write([]byte(fmt.Sprintf("failed setting up test server: %s", err)))1433 return
1434 }
1435
Description
It is recommended to use fmt.Fprint (and friends) instead of writing the
result of an fmt.Sprint (and friends) call to write to an io.Writer. This
reduces the number of allocations required, therefore improving performance.
Bad practice
package main
import (
"fmt"
"io"
)
func foo(w io.Writer, a int) {
w.Write([]byte(fmt.Sprintf("A: %d", a)))
}
Recommended
package main
import (
"fmt"
"io"
)
func foo(w io.Writer, a int) {
fmt.Fprintf(w, "A: %d", a)
}