Copy of large value in
range CRT-P0005
Performance
Major
8 months ago
—
a year old
copy of kgm.ams (32768 bytes) can be avoided with &kgm.ams
1102 defer kgm.RUnlock()
1103
1104 var minTS *pdpb.Timestamp
1105 for i, am := range kgm.ams {1106 if kgm.kgs[i] != nil {
1107 kgTotalCount++
1108 }copy of s.ams (32768 bytes) can be avoided with &s.ams
100 defer s.Unlock()
101
102 wg := sync.WaitGroup{}
103 for _, am := range s.ams { 104 if am != nil {
105 wg.Add(1)
106 go func(am *AllocatorManager) {
Description
Use pointer to slice or array, to avoid copying the value that is ranged
over.
Bad practice
var xs [2048]byte
for _, x := range xs { // copies 2048 bytes
// Loop body.
}
Recommended
var xs [2048]byte
for _, x := range &xs { // only address is copied now
// Loop body.
}