Unnecessary block CRT-A0008
Anti-pattern
Major
8 months ago
—
4 years old
case statement doesn't require a block statement
360 log.Info("drive slow node scheduler is stopped")
361 return
362 case <-ticker.C:
363 {364 // If enabled, exit.
365 if exists, _ := c.schedulers.IsSchedulerExisted(schedulers.EvictSlowTrendName); exists {
366 returnblock doesn't have definitions, can be simply deleted
355 region2 := tc.GetRegion(2)
356 region4 := tc.GetRegion(4)
357 // Adds operator and pushes to the notifier queue.
358 {359 re.True(op1.Start())
360 oc.SetOperator(op1)
361 re.True(op3.Start())block doesn't have definitions, can be simply deleted
160 })
161 // - A new PD joins an existing cluster.
162 // - A deleted PD joins to previous cluster.
163 {164 // First adds member through the API
165 addResp, err = etcdutil.AddEtcdMember(client, []string{cfg.AdvertisePeerUrls})
166 if err != nil {case statement doesn't require a block statement
61
62 switch *style {
63 case "transfer-counter":
64 {65 if *operator == "" {
66 Logger.Fatal("need to specify one operator")
67 }block doesn't have definitions, can be simply deleted
238 re.Equal(float64(-i*3)+100, x)
239 }
240
241 { // check all dimensions242 for k := 1; k < DimLen; k++ {
243 topn := make([]float64, 0, N)
244 for _, it := range tn.GetAllTopN(k) {
Description
It is not recommended to use unnecessary blocks.
Blocks aren't necessary unless scopes need to be separated. If a scope is using values solely from the parent scope, it isn't needed.
Bad practice
var err error
{
err = fmt.Errorf("some error occurred")
}
Recommended
err := fmt.Errorf("some error occurred")
Bad practice
x := 1
{
x += 4
}
Recommended
x := 1
x += 4