Appending to dictionary immediately following its definition PY-W0072
Anti-pattern
Major
2 months ago
—
4 months old
Appending to list immediately following its definition
1356
1357 # Store all extra keys in extra_dict and gather at end
1358 output_dict = {}
1359 extra_dict = {}1360
1361 extra_dict["schema_name"] = "qcschema_output"
1362 extra_dict["schema_version"] = _version_check(result, 2, "qcschema_output", lit)Appending to list immediately following its definition
1091 raise LoadError(f"QCSchema `qcschema_input` file requires '{key}' key", lit.filename)
1092 # Store all extra keys in extra_dict and gather at end
1093 input_dict = {}
1094 extra_dict = {}1095
1096 # Save schema name & version
1097 extra_dict["schema_name"] = "qcschema_input"Appending to list immediately following its definition
766 raise LoadError(f"QCSchema topology requires '{key}' key", lit.filename)
767
768 topology_dict = {}
769 extra_dict = {} 770
771 # Save schema name & version
772 extra_dict["schema_name"] = "qcschema_molecule"
Description
Instead of adding items to a dictionary just after creation, it should be refactored to add those items into the dict definition itself.
Bad practice
env = {}
env['HOST'] = 'example.com'
env['PORT'] = 8080
Recommended
env = {'HOST': 'example.com', 'PORT': 8080}