Unnecessary
delete statement in a local scope PTC-W0043
Anti-pattern
Major
3 months ago
—
4 months old
Unnecessary
del statement in a local scope200 del shell_map
201 del shell_types
202 del nexps
203 del exponents204
205 result["obasis"] = MolecularBasis(shells, CONVENTIONS, "L2")
206 nbasis = fchk["Number of basis functions"]Unnecessary
del statement in a local scope199 counter += n
200 del shell_map
201 del shell_types
202 del nexps203 del exponents
204
205 result["obasis"] = MolecularBasis(shells, CONVENTIONS, "L2")Unnecessary
del statement in a local scope198 )
199 counter += n
200 del shell_map
201 del shell_types202 del nexps
203 del exponents
204Unnecessary
del statement in a local scope197 )
198 )
199 counter += n
200 del shell_map201 del shell_types
202 del nexps
203 del exponentsUnnecessary
del statement in a local scope331 for ell in sorted(set(ls)):
332 offsets.append(offset)
333 offset += (2 * ell + 1) * (ell == ls).sum()
334 del offset335
336 # Fill in the coefficients
337 iorb = 0
Description
Passing a local variable to a del statement results in that variable being removed from the local namespace.
When exiting a function all local variables are deleted, so it is unnecessary to explicitly delete variables in such cases.
It is recommended to remove this del statement.
Not preferred:
def my_func():
task = do_some_task()
evaluate_task(task)
del task # This is unnecessary.
Preferred:
def my_func():
task = do_some_task()
evaluate_task(task)