if statement can be simplified PYL-R1703
Anti-pattern
Major
6 months ago
—
6 months old
The if statement can be replaced with 'return bool(test)'
97 else:
98 continue
99
100 if guess == secret_word:101 return True
102 else:
103 return False
Description
The highlighted if block can be refactored into a simplified statement, increasing its readability.
Bad practice
def simplifiable_if(arg, arg2):
if arg and not arg2:
var = True
else:
var = False
return var
Recommended
def simplifiable_if(arg, arg2):
var = bool(arg and not arg2)
return var