JS-0043 @ 9ddde75 • smalos / nubuilder

Run summary

a year ago

fedc680..9ddde75

49 s

Invalid variable usage JS-0043

Anti-pattern

Critical

147 occurrences in this check

'i' used outside of binding context.

core/nureportdrag.js

 292    grp = $('#nuSection' + min).attr('data-group')
 293    sec = $('#nuSection' + min).attr('data-section')
 294
 295    for (var i = 0; i < sel.length; i++) { 296      o = this.getObject(sel[i].id)
 297      S = this.sectionOfObject(sel[i].id)
 298      g = $('#nuSection' + S).attr('data-group')

'i' used outside of binding context.

core/nureportdrag.js

 292    grp = $('#nuSection' + min).attr('data-group')
 293    sec = $('#nuSection' + min).attr('data-section')
 294
 295    for (var i = 0; i < sel.length; i++) { 296      o = this.getObject(sel[i].id)
 297      S = this.sectionOfObject(sel[i].id)
 298      g = $('#nuSection' + S).attr('data-group')

'i' used outside of binding context.

core/nureportdrag.js

 292    grp = $('#nuSection' + min).attr('data-group')
 293    sec = $('#nuSection' + min).attr('data-section')
 294
 295    for (var i = 0; i < sel.length; i++) { 296      o = this.getObject(sel[i].id)
 297      S = this.sectionOfObject(sel[i].id)
 298      g = $('#nuSection' + S).attr('data-group')

'i' used outside of binding context.

core/nureportdrag.js

 293    sec = $('#nuSection' + min).attr('data-section')
 294
 295    for (var i = 0; i < sel.length; i++) {
 296      o = this.getObject(sel[i].id) 297      S = this.sectionOfObject(sel[i].id)
 298      g = $('#nuSection' + S).attr('data-group')
 299      s = $('#nuSection' + S).attr('data-section')

'i' used outside of binding context.

core/nureportdrag.js

 294
 295    for (var i = 0; i < sel.length; i++) {
 296      o = this.getObject(sel[i].id)
 297      S = this.sectionOfObject(sel[i].id) 298      g = $('#nuSection' + S).attr('data-group')
 299      s = $('#nuSection' + S).attr('data-section')
 300      o.width = nuRemovePX($('#' + o.id).css('width'))

'i' used outside of binding context.

core/nureportdrag.js

 285
 286    let o, S, g, s, T
 287
 288    for (var i = 0; i < sel.length; i++) { 289      min = Math.min(min, this.sectionOfObject(sel[i].id))
 290    }
 291

'i' used outside of binding context.

core/nureportdrag.js

 285
 286    let o, S, g, s, T
 287
 288    for (var i = 0; i < sel.length; i++) { 289      min = Math.min(min, this.sectionOfObject(sel[i].id))
 290    }
 291

'i' used outside of binding context.

core/nureportdrag.js

 285
 286    let o, S, g, s, T
 287
 288    for (var i = 0; i < sel.length; i++) { 289      min = Math.min(min, this.sectionOfObject(sel[i].id))
 290    }
 291

'i' used outside of binding context.

core/nureportdrag.js

 286    let o, S, g, s, T
 287
 288    for (var i = 0; i < sel.length; i++) {
 289      min = Math.min(min, this.sectionOfObject(sel[i].id)) 290    }
 291
 292    grp = $('#nuSection' + min).attr('data-group')

'i' used outside of binding context.

core/nureportdrag.js

 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2))
 674  }
 675
 676  for (var i = 0; i < s.length; i++) { 677    var o = nuDragR.getObject(s[i].id)
 678    o.left = r - o.width - (o.borderWidth * 2)
 679

'i' used outside of binding context.

core/nureportdrag.js

 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2))
 674  }
 675
 676  for (var i = 0; i < s.length; i++) { 677    var o = nuDragR.getObject(s[i].id)
 678    o.left = r - o.width - (o.borderWidth * 2)
 679

'i' used outside of binding context.

core/nureportdrag.js

 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2))
 674  }
 675
 676  for (var i = 0; i < s.length; i++) { 677    var o = nuDragR.getObject(s[i].id)
 678    o.left = r - o.width - (o.borderWidth * 2)
 679

'i' used outside of binding context.

core/nureportdrag.js

 674  }
 675
 676  for (var i = 0; i < s.length; i++) {
 677    var o = nuDragR.getObject(s[i].id) 678    o.left = r - o.width - (o.borderWidth * 2)
 679
 680    nuDragR.setObject(o)

'o' used outside of binding context.

core/nureportdrag.js

 674  }
 675
 676  for (var i = 0; i < s.length; i++) {
 677    var o = nuDragR.getObject(s[i].id) 678    o.left = r - o.width - (o.borderWidth * 2)
 679
 680    nuDragR.setObject(o)

'o' used outside of binding context.

core/nureportdrag.js

 675
 676  for (var i = 0; i < s.length; i++) {
 677    var o = nuDragR.getObject(s[i].id)
 678    o.left = r - o.width - (o.borderWidth * 2) 679
 680    nuDragR.setObject(o)
 681  }

'o' used outside of binding context.

core/nureportdrag.js

 675
 676  for (var i = 0; i < s.length; i++) {
 677    var o = nuDragR.getObject(s[i].id)
 678    o.left = r - o.width - (o.borderWidth * 2) 679
 680    nuDragR.setObject(o)
 681  }

'o' used outside of binding context.

core/nureportdrag.js

 675
 676  for (var i = 0; i < s.length; i++) {
 677    var o = nuDragR.getObject(s[i].id)
 678    o.left = r - o.width - (o.borderWidth * 2) 679
 680    nuDragR.setObject(o)
 681  }

'o' used outside of binding context.

core/nureportdrag.js

 677    var o = nuDragR.getObject(s[i].id)
 678    o.left = r - o.width - (o.borderWidth * 2)
 679
 680    nuDragR.setObject(o) 681  }
 682
 683  nuLoadReport()

'i' used outside of binding context.

core/nureportdrag.js

 668  nuDragR.dragging = true
 669  // var gs = nuDragR.getGroupAndSection(s[0].id);
 670
 671  for (var i = 0; i < s.length; i++) { 672    var o = nuDragR.getObject(s[i].id)
 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2))
 674  }

'i' used outside of binding context.

core/nureportdrag.js

 668  nuDragR.dragging = true
 669  // var gs = nuDragR.getGroupAndSection(s[0].id);
 670
 671  for (var i = 0; i < s.length; i++) { 672    var o = nuDragR.getObject(s[i].id)
 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2))
 674  }

'i' used outside of binding context.

core/nureportdrag.js

 668  nuDragR.dragging = true
 669  // var gs = nuDragR.getGroupAndSection(s[0].id);
 670
 671  for (var i = 0; i < s.length; i++) { 672    var o = nuDragR.getObject(s[i].id)
 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2))
 674  }

'i' used outside of binding context.

core/nureportdrag.js

 669  // var gs = nuDragR.getGroupAndSection(s[0].id);
 670
 671  for (var i = 0; i < s.length; i++) {
 672    var o = nuDragR.getObject(s[i].id) 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2))
 674  }
 675

'o' used outside of binding context.

core/nureportdrag.js

 669  // var gs = nuDragR.getGroupAndSection(s[0].id);
 670
 671  for (var i = 0; i < s.length; i++) {
 672    var o = nuDragR.getObject(s[i].id) 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2))
 674  }
 675

'o' used outside of binding context.

core/nureportdrag.js

 670
 671  for (var i = 0; i < s.length; i++) {
 672    var o = nuDragR.getObject(s[i].id)
 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2)) 674  }
 675
 676  for (var i = 0; i < s.length; i++) {

'o' used outside of binding context.

core/nureportdrag.js

 670
 671  for (var i = 0; i < s.length; i++) {
 672    var o = nuDragR.getObject(s[i].id)
 673    r = Math.max(r, o.left + o.width - (o.borderWidth * 2)) 674  }
 675
 676  for (var i = 0; i < s.length; i++) {

Description

Variables should be used inside of their binding context. This helps avoid difficult bugs with variable hoisting. It is a bad practice to use var declarations because variables declared using var can be accessed in a function-wide scope. They can even be accessed before declaration. In such cases, their value would be undefined because only declarations and not initializations are hoisted.

Bad Practice

function doIf() {
    if (cond()) {
        var build = true;
    }
    console.log(build);
}

function doIfElse() {
    if (cond()) {
        var build = true;
    } else {
        var build = false;
    }
    console.log(build)
}

smalos / nubuilder_dev

Bad Practice

Recommended