Re-defined variable from outer scope PYL-W0621
Anti-pattern
Major
22 days ago
—
5 years old
Redefining name 'json' from outer scope (line 9)
2153 return obj
2154
2155
2156def _unwrap(json):2157 """Converts a JSON response to one or more :class:`RestObj` instances.
2158
2159 If the JSON contains a .items property, only those items are converted and returned.Redefining name 'json' from outer scope (line 9)
629 stream=None,
630 verify=None,
631 cert=None,
632 json=None, 633 ):
634 url = self._build_url(url)
635 verify = verify or self.verifyRedefining name 'folders_list' from outer scope (line 53)
32 A list of directory information which can be user to map local and SAS folder structure.
33 """
34 files_list = []
35 folders_list = []36
37 for root, _, src_files in os.walk(source_path):
38 for src_file in src_files:Redefining name 'files_list' from outer scope (line 53)
31 d_list
32 A list of directory information which can be user to map local and SAS folder structure.
33 """
34 files_list = []35 folders_list = []
36
37 for root, _, src_files in os.walk(source_path):Redefining name 'pickle_model' from outer scope (line 9)
15 try:
16 global model
17 except NameError:
18 with open(Path(settings.pickle_path) / "RandomForest.pickle", "rb") as pickle_model:19 model = pickle.load(pickle_model)
20
21
Description
The local variable name hides the variable defined in the outer scope, making it inaccessible and might confuse.
Bad practice
filename = 'myfile.txt'
def read_file(filename): # This shadows the global `filename`
with open(filename) as file:
return file.readlines()
Preferred:
FILENAME = 'myfile.txt' # renamed global to UPPER_CASE as convention
def read_file(filename):
with open(filename) as file:
return file.readlines()
Bad practice
Another usual suspect of this is when you use the same parameter name inside a function as the global variable you are using. For example:
def run_app(app):
# This `app` shadows the global app...
app.run()
if __name__ == '__main__':
app = MyApp() # This is a global variable!
run_app(app)
Preferred:
To avoid this re-defining of a global, consider not defining app as a global, but inside a main() function instead:
def run_app(app):
# There is no longer a global `app` variable.
app.run()
def main():
app = MyApp()
run_app(app)
if __name__ == '__main__':
main()