Unassigned string statement PYL-W0105
Anti-pattern
Minor
5 months ago
—
a year old
String statement has no effect
884 f"predictions]\n{'':4}else:\n"
885 f"{'':8}predictions = [p.tolist() for p in predictions]\n"
886 )
887 """ 888 input_array = pd.DataFrame(
889 {"var1": var1, "var2": var2, "var3": var3}
890 )String statement has no effect
1846 f"{'':8}index = np.argmax(prediction.iloc[0:, 1:].values, axis=1)\n"
1847 f"{'':8}return pd.DataFrame({{'{metrics[0]}': np.array(target_values)[index], '{metrics[1]}': np.max(prediction.iloc[0:, 1:], axis=1)}})\n"
1848 )
1849 """1850 target_values = ['A', 'B', 'C']
1851 if input_array.shape[0] == 1:
1852 Classification = target_values[prediction[1][1:].index(max(prediction[1][1:]))]String statement has no effect
1953 f"{'':8}output_table = pd.DataFrame(prediction, columns={metrics})\n"
1954 f"{'':8}return output_table"
1955 )
1956 """1957 if input_array.shape[0] == 1:
1958 return prediction[0][0], prediction[0][1], prediction[0][2]
1959 else:String statement has no effect
1722 f"{'':4}else:\n"
1723 f"{'':8}return pd.DataFrame(prediction, columns={metrics})"
1724 )
1725 """1726 if input_array.shape[0] == 1:
1727 return prediction[0][0], prediction[0][1], prediction[0][2]
1728 else:String statement has no effect
1932 f"{'':8}prediction.columns = {metrics}\n"
1933 f"{'':8}return prediction"
1934 )
1935 """1936 if input_array.shape[0] == 1:
1937 return prediction[1][0], prediction[1][1], prediction[1][2], prediction[1][3]
1938 else:
Description
The string statement has not been assigned to anything. This is pointless and should be removed if not necessary. In case this is supposed to describe what's happening in the code, it is recommended to use comments or docstrings instead.
Not preferred:
'Define a function to add 2 numbers here.'
def add(a, b):
return a + b
Preferred:
Use Comments:
# Define a function to add 2 numbers here.
def add(a, b):
return a + b
or, use docstrings:
def add(a, b):
'''Function to add 2 numbers here.'''
return a + b