Duplicate dictionary keys PYL-W0109
Bug risk
Major
4 years ago
—
5 years old
Duplicate key 'TF_CUDA_CLANG' in dictionary
1013 )
1014 major, minor, patch = env.PYTHON_VERSION.split('.')
1015 lib = os.path.join('lib', 'python' + major + '.' + minor, 'site-packages')
1016 new_env = {1017 'PATH': os.environ['PATH'],
1018 'PYTHON_BIN_PATH': env.BIN_PYTHON,
1019 'PYTHON_LIB_PATH': os.path.join(env.PREFIX, lib),
Description
This dictionary expression binds the same key multiple times. This may lead to unintentional behaviour as the key will always map the last value provided to it. It is recommended to have unique keys.
Bad practice
Here, the key random is provided twice.
DICT = {
"some": "some",
"random": "random",
"dict": "dict",
"values": "values",
"random": "different",
}
Recommended
All keys should be unique.
DICT = {
"some": "some",
"dict": "dict",
"values": "values",
"random": "different",
}