File opened without the
with statement PTC-W0010
Anti-pattern
Critical
4 years ago
—
5 years old
Use the
with statement to open a file349 """
350 for var in glob.glob(os.path.join(ENV_DIRECTORY, '*')):
351 if os.path.isfile(var):
352 os.environ[os.path.basename(var)] = os.path.expandvars(open(var, encoding='utf-8').read())353
354
355def set_installed_packages():Use the
with statement to open a file303 """
304 version = None
305 if os.path.exists(path):
306 version = open(path, 'r', encoding='utf-8').read().strip()307
308 if version:
309 return re.sub(r'^python-', '', version)Use the
with statement to open a file282 if not os.path.isfile(path):
283 return None
284
285 conf = open(path, 'rt').read()286 conf = os.path.expandvars(conf)
287
288 config = configparser.SafeConfigParser()Use the
with statement to open a file 620 file.write('lore' + os.linesep)
621
622 python_version = parsed.python_version or lore.env.read_version('runtime.txt') or '3.6.6'
623 open('runtime.txt', 'w').write('python-' + python_version + '\n') 624
625 module = os.path.join(root, name, '__init__.py')
626 if not os.path.exists(os.path.dirname(module)):
Description
Opening a file using with statement is preferred as function open implements the context manager protocol that releases the resource when it is outside of the with block. Not doing so requires you to manually release the resource.
Bad practice
f = open('/tmp/.deepsource.toml', 'w')
f.write("config file.")
# No `f.close()` statement: file may remain unaccessible
Preferred:
with open('/tmp/.deepsource.toml', 'w') as f:
f.write("config file.")