Consider merging collapsible if statements
1245 strategy_colname = kwargs.get("strategy_title", "Strategy")
1246 active = kwargs.get("active", "False")
1247
1248 if isinstance(returns, _pd.DataFrame):1249 if len(returns.columns) > 1:
1250 if isinstance(strategy_colname, str):
1251 strategy_colname = list(returns.columns)Consider merging collapsible if statements
664 strategy_title = kwargs.get("strategy_title", "Strategy")
665 active = kwargs.get("active_returns", "False")
666
667 if isinstance(returns, _pd.DataFrame): 668 if len(returns.columns) > 1 and isinstance(strategy_title, str):
669 strategy_title = list(returns.columns)
670Consider merging collapsible if statements
515 strategy_title = kwargs.get("strategy_title", "Strategy")
516 active = kwargs.get("active_returns", "False")
517
518 if isinstance(returns, _pd.DataFrame): 519 if len(returns.columns) > 1 and isinstance(strategy_title, str):
520 strategy_title = list(returns.columns)
521Consider merging collapsible if statements
85 returns = _utils._prepare_returns(returns)
86
87 strategy_title = kwargs.get("strategy_title", "Strategy")
88 if isinstance(returns, _pd.DataFrame): 89 if len(returns.columns) > 1 and isinstance(strategy_title, str):
90 strategy_title = list(returns.columns)
91
Description
Nested if statements can be collapsed into a single if statement by separating their condition using and operator.
Merging collapsible if statements increases the code's readability.
Bad practice
if condition1:
if condition2:
dosomething()
Preferred
if condition1 and condition2:
dosomething()
Exception:
DeepSource will not raise this issue when the nested if statements have comments in between them, as it could be explaining why the nested if is in place.