Consider merging collapsible if statements
224 "rolling_volatility",
225 ]
226
227 if function not in unnecessary_function_calls:228 if rf > 0:
229 return to_excess_returns(data, rf, nperiods)
230 return data
Description
Nested if
statements can be collapsed into a single if
statement by separating their condition using and
operator.
Merging collapsible if
statements increases the code's readability.
Bad practice
if condition1:
if condition2:
dosomething()
Preferred
if condition1 and condition2:
dosomething()
Exception:
DeepSource will not raise this issue when the nested if
statements have comments in between them, as it could be explaining why the nested if
is in place.