Function contains unused argument PYL-W0613
Anti-pattern
Major
3 years ago
—
5 years old
Unused argument 'annualize'
246 return res
247
248
249def adjusted_sortino(returns, rf=0, periods=252, annualize=True):250 """
251 Jack Schwager's version of the Sortino ratio allows for
252 direct comparisons to the Sharpe. See here for more info:Unused argument 'periods'
246 return res
247
248
249def adjusted_sortino(returns, rf=0, periods=252, annualize=True):250 """
251 Jack Schwager's version of the Sortino ratio allows for
252 direct comparisons to the Sharpe. See here for more info:Unused argument 'rf'
246 return res
247
248
249def adjusted_sortino(returns, rf=0, periods=252, annualize=True):250 """
251 Jack Schwager's version of the Sortino ratio allows for
252 direct comparisons to the Sharpe. See here for more info:
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42