PTC-W0048 · `if` statements can be merged

ranaroussi / quantstats

Active

if statements can be merged PTC-W0048

Anti-pattern

Major

3 years ago — 3 years old

Consider merging collapsible if statements

281        raise ValueError("`returns` must be a pandas Series, "
282                         "but a multi-column DataFrame was passed")
283
284    if benchmark is not None:285        if isinstance(returns, _pd.DataFrame) and len(returns.columns) > 1:
286            raise ValueError("`benchmark` must be a pandas Series, "
287                             "but a multi-column DataFrame was passed")

Description

Nested if statements can be collapsed into a single if statement by separating their condition using and operator. Merging collapsible if statements increases the code's readability.

Bad practice

if condition1:
    if condition2:
        dosomething()

Preferred

if condition1 and condition2:
    dosomething()

Exception:

DeepSource will not raise this issue when the nested if statements have comments in between them, as it could be explaining why the nested if is in place.