Found redundant literal in a logical expression JS-W1043
Anti-pattern
Minor
a month ago
—
2 months old
Unexpected constant truthiness on the left-hand side of a
|| expression21 getTokenInfo: (networkName, ticker) => {
22 const { tokenInfo } = get()
23 const tokenId = tokenInfo[networkName]?.[ticker] ?? "undefined"
24 return { ticker: ticker, tokenId: tokenId } || undefined25 },
26 removeTokenInfo: (networkName, ticker) => {
27 set(
Description
Expressions that consistently result in either true or false when comparing values, and logical operations like ||, &&, and ?? that consistently either skip or fully evaluate their operands, often indicate mistakes. Logical operations that always yield the same result could lead to unexpected behavior or bugs in the program.
Bad Practice
const arrIsEmpty = someArr === [] // Will always evaluate to false
Recommended
const arrIsEmpty = someArr.length === 0