Use shorthand promise methods JS-C1004
Anti-pattern
Minor
a month ago
—
2 months old
Use shorthand promise resolution method
80 )
81 }
82 derivePrivateKey(decryptedSeedBytes: Uint8Array, args: MinaSpecificArgs) {
83 return new Promise<Uint8Array>((resolve) => 84 resolve(deriveMinaPrivateKey(args, decryptedSeedBytes)), 85 ) 86 }
87}
88// new functional implementation of MinaPayloadUse shorthand promise resolution method
75 network = Network.Mina
76
77 derivePublicKey(privateKey: Uint8Array) {
78 return new Promise<string>((resolve) => 79 resolve(deriveMinaPublicKey(privateKey)), 80 ) 81 }
82 derivePrivateKey(decryptedSeedBytes: Uint8Array, args: MinaSpecificArgs) {
83 return new Promise<Uint8Array>((resolve) =>Use shorthand promise resolution method
67 )
68 }
69 derivePrivateKey(decryptedSeedBytes: Uint8Array, args: EthereumSpecificArgs) {
70 return new Promise<Uint8Array>((resolve) =>71 resolve(deriveEthereumPrivateKey(args, decryptedSeedBytes)),72 )73 }
74}
75Use shorthand promise resolution method
62 network = Network.Ethereum
63
64 derivePublicKey(privateKey: Uint8Array) {
65 return new Promise<string>((resolve) =>66 resolve(deriveEthereumPublicAddress(privateKey)),67 )68 }
69 derivePrivateKey(decryptedSeedBytes: Uint8Array, args: EthereumSpecificArgs) {
70 return new Promise<Uint8Array>((resolve) =>
Description
If the executor argument to a promise constructor only calls the reject or resolve and exits, then the code can refactored to use Promise#reject or Promise#resolve instead.
Bad Practice
new Promise((resolve, reject) => {
resolve(getItem())
})
new Promise(function (resolve, reject) {
reject("oops")
})
Recommended
Promise.resolve(getItem())
Promise.reject("oops")