Avoid using wildcard imports JS-C1003
Anti-pattern
Minor
a month ago
—
2 months old
Explicitly import the specific method needed
20 KeyAgentType,
21 type SerializableKeyAgentData,
22} from "../../src/types"
23import * as util from "../../src/util/bip39" 24
25// Provide the passphrase for testing purposes
26const params = {Explicitly import the specific method needed
2import { Mina } from "@palladxyz/mina-core"
3import { constructTransaction } from "@palladxyz/pallad-core"
4import { Network } from "@palladxyz/pallad-core"
5import * as bip32 from "@scure/bip32" 6import Client from "mina-signer"
7import { expect } from "vitest"
8Explicitly import the specific method needed
14 KeyAgentType,
15 type SerializableKeyAgentData,
16} from "../../src/types"
17import * as util from "../../src/util/bip39" 18
19// Provide the passphrase for testing purposes
20const params = {Explicitly import the specific method needed
15 MinaDerivationArgs,
16 MinaSpecificArgs,
17} from "../../src/chains/Mina"
18import * as bip39 from "../../src/util/bip39" 19
20// Provide the passphrase for testing purposes
21const params = {Explicitly import the specific method needed
1import { mnemonic } from "@palladxyz/common"
2import { Mina } from "@palladxyz/mina-core"
3import { Network, constructTransaction } from "@palladxyz/pallad-core"
4import * as bip32 from "@scure/bip32" 5import Client from "mina-signer"
6import { expect } from "vitest"
7
Description
Wildcard imports are easier to write, but make it harder to pick out the specific functions or objects from a dependency that are used in a file.
import * from 'module';
// there is no clear way to tell if
// `someFunction` has been imported
// from 'module'.
someFunction();
Therefore, it is recommended to explicit imports wherever possible.
NOTE: Some libraries do not expose themselves as ESModules. In cases like these, it is recommended to use a skipcq comment to suppress this issue.
Bad Practice
import * as axios from 'axios'
import * as Sentry from '@sentry/node'
try {
const result = await axios.get();
// ...
} catch (err) {
Sentry.captureException(err);
}
Recommended
import axios from 'axios'
// skipcq: JS-C1003 - sentry does not expose itself as an ES Module.
import * as Sentry from '@sentry/node'
try {
const result = await axios.get();
// ...
} catch (err) {
Sentry.captureException(err);
}