Detected empty functions JS-0321
Anti-pattern
Minor
a month ago
—
2 months old
Unexpected empty constructor
29export class VaultService implements IVaultService {
30 private static instance: VaultService
31
32 private constructor() {} 33
34 public static getInstance() {
35 if (!VaultService.instance) {Unexpected empty async arrow function
12 let instance: SessionKeyAgentBase
13 let networkType: Mina.NetworkType
14
15 beforeEach(async () => {}) 16
17 describe("Mina KeyAgent", () => {
18 beforeEach(() => {
Description
Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.
Bad Practice
getUser('SwaGaLisTiQuE', () => {})
Recommended
getUser('SwaGaLisTiQuE', () => {
// empty because <reason>
})