Class methods should utilize
this JS-0105
Anti-pattern
Minor
a month ago
—
2 months old
Expected 'this' to be used by class method 'createProviderRpcError'
87 }
88 }
89
90 private createProviderRpcError(code: number, message: string) { 91 const error = new Error(`${code} - ${message}`)
92 error.name = "ProviderRpcError"
93 return errorExpected 'this' to be used by class async method 'verifyInitialized'
74 await this._vault.unlockWallet(passphrase as string)
75 }
76
77 async verifyInitialized() { 78 const { PalladApp } = await chrome.storage.local.get("PalladApp")
79 if (!PalladApp) return false
80 return !PalladApp.includes("UNINITIALIZED")Expected 'this' to be used by class async method 'rehydrate'
260 }
261 }
262
263 async rehydrate() {264 return useVault.persist.rehydrate()
265 }
266Expected 'this' to be used by class async method 'setEnabled'
143 return permissions[origin] === AuthorizationState.BLOCKED
144 }
145
146 async setEnabled({ origin }: { origin: ZkAppUrl }) {147 const { permissions } = await chrome.storage.local.get({
148 permissions: true,
149 })Expected 'this' to be used by class async method 'isBlocked'
136 return permissions[origin] === AuthorizationState.ALLOWED
137 }
138
139 async isBlocked({ origin }: { origin: ZkAppUrl }) {140 const { permissions } = await chrome.storage.local.get({
141 permissions: true,
142 })
Description
If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())
Bad Practice
class Person {
sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
const person = new Person();
person.sayHi();
Recommended
class Person {
static sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
Person.sayHi();