Found some unnecessary nested blocks JS-0072
Anti-pattern
Minor
a month ago
—
2 months old
Nested block is redundant
189 throw this.createProviderRpcError(4200, "Unsupported Method")
190 }
191 case "mina_requestNetwork": {
192 {193 const userConfirmed = await this.userPrompt({194 inputType: "confirmation",195 metadata: {196 title: "Request to current Mina network information.",197 payload: JSON.stringify(params),198 },199 })200 if (!userConfirmed) {201 throw this.createProviderRpcError(4001, "User Rejected Request")202 }203 const requestNetworkResponse = await this._vault.requestNetwork()204 return requestNetworkResponse as unknown as T205 }206 }
207 case "mina_sign":
208 case "mina_createNullifier":
Description
In JavaScript, prior to ES6, standalone code blocks delimited by curly braces do not create a new scope and have no use.
For example, these curly braces do nothing to foo:
{
var foo = bar();
}
In ES6, code blocks may create a new scope if a block-level binding (let and const), a class declaration or a function declaration (in strict mode) are present. A block is not considered redundant in these cases.
Bad Practice
{}
if (foo) {
bar();
{
baz();
}
}
function bar() {
{
baz();
}
}
{
function foo() {}
}
{
aLabel: {
}
}
Recommended
while (foo) {
bar();
}
if (foo) {
if (bar) {
baz();
}
}
function bar() {
baz();
}
{
let x = 1;
}
{
const y = 1;
}
{
class Foo {}
}
aLabel: {}